Fix for HW decode & High10 - Tdarr_Plugin_bsh1_Boosh_FFMPEG_QSV_HEVC.js #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New fix for HW decode. H264 High10 is the problem. Enable SW decode for that and normal HW decode on the rest.
|
Worth checking. Do we have enough tests for this one? I could spend a bit of time writing up more tests on a future pull |
|
Ty, yeah suppose could be handy. What I typically do is this: So can modify the video stream in the test file to have whatever is needed for the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous fix broke 10bit encodes. New fix sorts that & fixes up when HW decode should be used. H264 High10 was the problem all along, QSV seems to be happy decoding most 10bit files but High10 throws a spanner in. So now we enable SW decode for anything High10 and use normal HW decode on the rest. Pixel format cmd has a small adjustment depending on HW or SW decode.
Got some new test files to cover 10bit files better in future. Also I don't think there's test data for High10 files. Not sure if that's worth setting up now that Flows is a thing?